kybaaz/linux-xiaomi-chiron
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
linux-xiaomi-chiron/drivers/pinctrl/aspeed
History
Andrew Jeffery c1432423a1 pinctrl: aspeed: Fix spurious mux failures on the AST2500 
Commit 674fa8daa8 ("pinctrl: aspeed-g5: Delay acquisition of regmaps")
was determined to be a partial fix to the problem of acquiring the LPC
Host Controller and GFX regmaps: The AST2500 pin controller may need to
fetch syscon regmaps during expression evaluation as well as when
setting mux state. For example, this case is hit by attempting to export
pins exposing the LPC Host Controller as GPIOs.

An optional eval() hook is added to the Aspeed pinmux operation struct
and called from aspeed_sig_expr_eval() if the pointer is set by the
SoC-specific driver. This enables the AST2500 to perform the custom
action of acquiring its regmap dependencies as required.

John Wang tested the fix on an Inspur FP5280G2 machine (AST2500-based)
where the issue was found, and I've booted the fix on Witherspoon
(AST2500) and Palmetto (AST2400) machines, and poked at relevant pins
under QEMU by forcing mux configurations via devmem before exporting
GPIOs to exercise the driver.

Fixes: 7d29ed88ac ("pinctrl: aspeed: Read and write bits in LPC and GFX controllers")
Fixes: 674fa8daa8 ("pinctrl: aspeed-g5: Delay acquisition of regmaps")
Reported-by: John Wang <wangzqbj@inspur.com>
Tested-by: John Wang <wangzqbj@inspur.com>
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

Link: https://lore.kernel.org/r/20190829071738.2523-1-andrew@aj.id.au
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
2019-09-12 00:08:27 +01:00
..
Kconfig treewide: Add SPDX license identifier - Makefile/Kconfig 2019-05-21 10:50:46 +02:00
Makefile This is the bulk of pin control changes for the v5.3 kernel 2019-07-13 15:02:27 -07:00
pinctrl-aspeed-g4.c pinctrl: aspeed-g5: Delay acquisition of regmaps 2019-07-29 00:52:51 +02:00
pinctrl-aspeed-g5.c pinctrl: aspeed: Fix spurious mux failures on the AST2500 2019-09-12 00:08:27 +01:00
pinctrl-aspeed.c pinctrl: aspeed-g5: Delay acquisition of regmaps 2019-07-29 00:52:51 +02:00
pinctrl-aspeed.h This is the bulk of pin control changes for the v5.3 kernel 2019-07-13 15:02:27 -07:00
pinmux-aspeed.c pinctrl: aspeed: Fix spurious mux failures on the AST2500 2019-09-12 00:08:27 +01:00
pinmux-aspeed.h pinctrl: aspeed: Fix spurious mux failures on the AST2500 2019-09-12 00:08:27 +01:00