kybaaz/linux-xiaomi-chiron
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
linux-xiaomi-chiron/drivers/staging/android
History
Nicolai Stange 0fd9da9a97 staging/android: sync_debug: unproxify debugfs files' fops 
Since commit 49d200deaa ("debugfs: prevent access to removed files'
private data"), a debugfs file's file_operations methods get proxied
through lifetime aware wrappers.

However, only a certain subset of the file_operations members is supported
by debugfs and ->compat_ioctl isn't among them -- it appears to be NULL
from the VFS layer's perspective.

This behaviour breaks the /sys/kernel/debug/sync/sw_sync file introduced
concurrently with commit a44eb74cd4 ("staging/android: move SW_SYNC_USER
to a debugfs file").

Since that file never gets removed, there is no file removal race and thus,
a lifetime checking proxy isn't needed.

Avoid the proxying for /sys/kernel/debug/sync/sw_sync by creating it via
debugfs_create_file_unsafe() rather than debugfs_create_file().
For consistency, do the same for /sys/kernel/debug/sync/info.

Fixes: 49d200deaa ("debugfs: prevent access to removed files' private data")
Fixes: a44eb74cd4 ("staging/android: move SW_SYNC_USER to a debugfs file")
Signed-off-by: Nicolai Stange <nicstange@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-06-17 21:24:41 -07:00
..
ion staging: android: ion: dummy: fix dereference of ERR_PTR 2016-04-29 17:40:50 -07:00
trace staging/android: rename sync.h to sync_debug.h 2016-06-17 21:17:40 -07:00
uapi staging/android: make sw_ioctl info internal to sw_sync.c 2016-06-17 21:17:40 -07:00
ashmem.c Merge branch 'mm-pkeys-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip 2016-03-20 19:08:56 -07:00
ashmem.h staging: android: Split uapi out of ashmem.h 2014-02-18 11:03:28 -08:00
Kconfig staging/android: add DEBUG_FS dependence on Kconfig 2016-06-17 21:17:40 -07:00
lowmemorykiller.c staging: lowmemorykiller: remove bogus NULL check 2016-04-29 17:58:02 -07:00
Makefile staging/android: make sync_timeline internal to sw_sync 2016-06-17 21:17:40 -07:00
sw_sync.c staging/android: rename sync.h to sync_debug.h 2016-06-17 21:17:40 -07:00
sync_debug.c staging/android: sync_debug: unproxify debugfs files' fops 2016-06-17 21:24:41 -07:00
sync_debug.h staging/android: add DEBUG_FS dependence on Kconfig 2016-06-17 21:17:40 -07:00
TODO staging/android: add TODO to de-stage android sync framework 2015-12-14 11:05:45 -08:00