Pablo Neira Ayuso 97840cb67f netfilter: nfnetlink: fix insufficient validation in nfnetlink_bind ... Make sure the netlink group exists, otherwise you can trigger an out of bound array memory access from the netlink_bind() path. This splat can only be triggered only by superuser. [ 180.203600] UBSan: Undefined behaviour in ../net/netfilter/nfnetlink.c:467:28 [ 180.204249] index 9 is out of range for type 'int [9]' [ 180.204697] CPU: 0 PID: 1771 Comm: trinity-main Not tainted 3.18.0-rc4-mm1+ #122 [ 180.205365] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.7.5-0-ge51488c-20140602_164612-nilsson.home.kraxel.org +04/01/2014 [ 180.206498] 0000000000000018 0000000000000000 0000000000000009 ffff88007bdf7da8 [ 180.207220] ffffffff82b0ef5f 0000000000000092 ffffffff845ae2e0 ffff88007bdf7db8 [ 180.207887] ffffffff8199e489 ffff88007bdf7e18 ffffffff8199ea22 0000003900000000 [ 180.208639] Call Trace: [ 180.208857] dump_stack (lib/dump_stack.c:52) [ 180.209370] ubsan_epilogue (lib/ubsan.c:174) [ 180.209849] __ubsan_handle_out_of_bounds (lib/ubsan.c:400) [ 180.210512] nfnetlink_bind (net/netfilter/nfnetlink.c:467) [ 180.210986] netlink_bind (net/netlink/af_netlink.c:1483) [ 180.211495] SYSC_bind (net/socket.c:1541) Moreover, define the missing nf_tables and nf_acct multicast groups too. Reported-by: Andrey Ryabinin <a.ryabinin@samsung.com> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>		2014-11-17 12:01:13 +01:00
..
ipset	netfilter: ipset: small potential read beyond the end of buffer	2014-11-11 13:46:37 +01:00
ipvs	ipvs: Keep skb->sk when allocating headroom on tunnel xmit	2014-11-12 11:03:04 +09:00
core.c
Kconfig	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2014-10-02 11:25:43 -07:00
Makefile
nf_conntrack_acct.c
nf_conntrack_amanda.c
nf_conntrack_broadcast.c
nf_conntrack_core.c	netfilter: conntrack: fix race in __nf_conntrack_confirm against get_next_corpse	2014-11-14 17:43:05 +01:00
nf_conntrack_ecache.c
nf_conntrack_expect.c
nf_conntrack_extend.c
nf_conntrack_ftp.c	netfilter: replace strnicmp with strncasecmp	2014-10-14 02:18:24 +02:00
nf_conntrack_h323_asn1.c
nf_conntrack_h323_main.c
nf_conntrack_h323_types.c
nf_conntrack_helper.c
nf_conntrack_irc.c
nf_conntrack_l3proto_generic.c
nf_conntrack_labels.c
nf_conntrack_netbios_ns.c
nf_conntrack_netlink.c
nf_conntrack_pptp.c
nf_conntrack_proto.c
nf_conntrack_proto_dccp.c
nf_conntrack_proto_generic.c
nf_conntrack_proto_gre.c
nf_conntrack_proto_sctp.c
nf_conntrack_proto_tcp.c	netfilter: nf_conntrack: allow server to become a client in TW handling	2014-10-22 14:12:50 +02:00
nf_conntrack_proto_udp.c
nf_conntrack_proto_udplite.c
nf_conntrack_sane.c
nf_conntrack_seqadj.c
nf_conntrack_sip.c	netfilter: replace strnicmp with strncasecmp	2014-10-14 02:18:24 +02:00
nf_conntrack_snmp.c
nf_conntrack_standalone.c
nf_conntrack_tftp.c
nf_conntrack_timeout.c
nf_conntrack_timestamp.c
nf_internals.h
nf_log.c	netfilter: replace strnicmp with strncasecmp	2014-10-14 02:18:24 +02:00
nf_log_common.c	netfilter: use IS_ENABLED(CONFIG_BRIDGE_NETFILTER)	2014-10-02 18:30:54 +02:00
nf_nat_amanda.c
nf_nat_core.c
nf_nat_ftp.c
nf_nat_helper.c
nf_nat_irc.c
nf_nat_proto_common.c
nf_nat_proto_dccp.c
nf_nat_proto_sctp.c
nf_nat_proto_tcp.c
nf_nat_proto_udp.c
nf_nat_proto_udplite.c
nf_nat_proto_unknown.c
nf_nat_sip.c	netfilter: replace strnicmp with strncasecmp	2014-10-14 02:18:24 +02:00
nf_nat_tftp.c
nf_queue.c	netfilter: use IS_ENABLED(CONFIG_BRIDGE_NETFILTER)	2014-10-02 18:30:54 +02:00
nf_sockopt.c
nf_synproxy_core.c
nf_tables_api.c	netfilter: nf_tables: restore synchronous object release from commit/abort	2014-11-12 12:06:24 +01:00
nf_tables_core.c
nf_tables_inet.c
nfnetlink.c	netfilter: nfnetlink: fix insufficient validation in nfnetlink_bind	2014-11-17 12:01:13 +01:00
nfnetlink_acct.c
nfnetlink_cthelper.c
nfnetlink_cttimeout.c
nfnetlink_log.c	netfilter: nf_log: release skbuff on nlmsg put failure	2014-10-24 14:34:11 +02:00
nfnetlink_queue_core.c	net: make skb_gso_segment error handling more robust	2014-10-20 12:38:13 -04:00
nfnetlink_queue_ct.c
nft_bitwise.c
nft_byteorder.c
nft_cmp.c
nft_compat.c	netfilter: nft_compat: use the match->table to validate dependencies	2014-11-12 12:06:24 +01:00
nft_counter.c
nft_ct.c
nft_expr_template.c
nft_exthdr.c
nft_hash.c
nft_immediate.c
nft_limit.c
nft_log.c
nft_lookup.c
nft_masq.c	netfilter: nf_tables: restrict nat/masq expressions to nat chain type	2014-10-13 20:42:00 +02:00
nft_meta.c
nft_nat.c	netfilter: nft_nat: dump attributes if they are set	2014-10-18 14:16:13 +02:00
nft_payload.c
nft_queue.c
nft_rbtree.c
nft_reject.c	netfilter: fix wrong arithmetics regarding NFT_REJECT_ICMPX_MAX	2014-10-07 20:16:31 +02:00
nft_reject_inet.c	netfilter: nft_reject: introduce icmp code abstraction for inet and bridge	2014-10-02 18:29:57 +02:00
x_tables.c
xt_addrtype.c
xt_AUDIT.c
xt_bpf.c
xt_cgroup.c
xt_CHECKSUM.c
xt_CLASSIFY.c
xt_cluster.c
xt_comment.c
xt_connbytes.c
xt_connlabel.c
xt_connlimit.c
xt_connmark.c
xt_CONNSECMARK.c
xt_conntrack.c
xt_cpu.c
xt_CT.c
xt_dccp.c
xt_devgroup.c
xt_dscp.c
xt_DSCP.c
xt_ecn.c
xt_esp.c
xt_hashlimit.c
xt_helper.c
xt_hl.c
xt_HL.c
xt_HMARK.c
xt_IDLETIMER.c
xt_ipcomp.c
xt_iprange.c
xt_ipvs.c
xt_l2tp.c
xt_LED.c
xt_length.c
xt_limit.c
xt_LOG.c
xt_mac.c
xt_mark.c
xt_multiport.c
xt_nat.c
xt_NETMAP.c
xt_nfacct.c
xt_NFLOG.c
xt_NFQUEUE.c
xt_osf.c
xt_owner.c
xt_physdev.c	netfilter: explicit module dependency between br_netfilter and physdev	2014-10-02 18:30:57 +02:00
xt_pkttype.c
xt_policy.c
xt_quota.c
xt_RATEEST.c	net: sched: make bstats per cpu and estimator RCU safe	2014-09-30 01:02:26 -04:00
xt_rateest.c
xt_realm.c
xt_recent.c
xt_REDIRECT.c
xt_repldata.h
xt_sctp.c
xt_SECMARK.c
xt_set.c
xt_socket.c
xt_state.c
xt_statistic.c
xt_string.c
xt_TCPMSS.c
xt_tcpmss.c
xt_TCPOPTSTRIP.c
xt_tcpudp.c
xt_TEE.c
xt_time.c
xt_TPROXY.c
xt_TRACE.c
xt_u32.c