kybaaz/linux-xiaomi-chiron
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

staging: comedi: refactor pcm3730 driver to remove forward declarations

Browse source 
Move the module_init/module_exit routines and the associated
struct comedi_driver and other variables to the end of the source.
This is more typical of how other drivers are written and removes
the need for the forward declarations.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten 2012-04-27 15:50:41 -07:00 • committed by Greg Kroah-Hartman
parent 5f01bd51f1
commit f3ebaf4b51
1 changed files with 19 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

42
drivers/staging/comedi/drivers/pcm3730.c
View file

@ -28,29 +28,6 @@ Configuration options:
#define PCM3730_DIB 2 #define PCM3730_DIB 2
#define PCM3730_DIC 3 #define PCM3730_DIC 3
static int pcm3730_attach(struct comedi_device *dev,
struct comedi_devconfig *it);
static int pcm3730_detach(struct comedi_device *dev);
static struct comedi_driver driver_pcm3730 = {
.driver_name = "pcm3730",
.module = THIS_MODULE,
.attach = pcm3730_attach,
.detach = pcm3730_detach,
};
static int __init driver_pcm3730_init_module(void)
{
return comedi_driver_register(&driver_pcm3730);
}
static void __exit driver_pcm3730_cleanup_module(void)
{
comedi_driver_unregister(&driver_pcm3730);
}
module_init(driver_pcm3730_init_module);
module_exit(driver_pcm3730_cleanup_module);
static int pcm3730_do_insn_bits(struct comedi_device *dev, static int pcm3730_do_insn_bits(struct comedi_device *dev,
struct comedi_subdevice *s, struct comedi_subdevice *s,
struct comedi_insn *insn, unsigned int *data) struct comedi_insn *insn, unsigned int *data)
@ -166,6 +143,25 @@ static int pcm3730_detach(struct comedi_device *dev)
return 0; return 0;
} }
static struct comedi_driver driver_pcm3730 = {
.driver_name = "pcm3730",
.module = THIS_MODULE,
.attach = pcm3730_attach,
.detach = pcm3730_detach,
};
static int __init driver_pcm3730_init_module(void)
{
return comedi_driver_register(&driver_pcm3730);
}
module_init(driver_pcm3730_init_module);
static void __exit driver_pcm3730_cleanup_module(void)
{
comedi_driver_unregister(&driver_pcm3730);
}
module_exit(driver_pcm3730_cleanup_module);
MODULE_AUTHOR("Comedi http://www.comedi.org"); MODULE_AUTHOR("Comedi http://www.comedi.org");
MODULE_DESCRIPTION("Comedi low-level driver"); MODULE_DESCRIPTION("Comedi low-level driver");
MODULE_LICENSE("GPL"); MODULE_LICENSE("GPL");