kybaaz/linux-xiaomi-chiron
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[media] media: lirc_dev: remove support for manually specifying minor number

Browse source 
All users of lirc_register_driver() uses dynamic minor allocation,
therefore we can remove the ability to explicitly request a given number.

This changes the function prototype of lirc_unregister_driver() to also
take a struct lirc_driver pointer as the sole argument.

Signed-off-by: David Härdeman <david@hardeman.nu>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
This commit is contained in:
David Härdeman 2017-06-25 09:31:24 -03:00 • committed by Mauro Carvalho Chehab
parent de226ec8a6
commit c3c6dd750e
4 changed files with 34 additions and 77 deletions
Download patch file Download diff file Expand all files Collapse all files

20
include/media/lirc_dev.h
View file

@ -116,10 +116,8 @@ static inline unsigned int lirc_buffer_write(struct lirc_buffer *buf,
*
* @name: this string will be used for logs
*
* @minor: indicates minor device (/dev/lirc) number for
* registered driver if caller fills it with negative
* value, then the first free minor number will be used
* (if available).
* @minor: the minor device (/dev/lircX) number for a registered
* driver.
*
* @code_length: length of the remote control key code expressed in bits.
*
@ -157,10 +155,12 @@ static inline unsigned int lirc_buffer_write(struct lirc_buffer *buf,
* device.
*
* @owner: the module owning this struct
*
* @irctl: the struct irctl for this LIRC device.
*/
struct lirc_driver {
char name[40];
int minor;
unsigned int minor;
__u32 code_length;
unsigned int buffer_size; /* in chunks holding one code each */
__u32 features;
@ -175,19 +175,17 @@ struct lirc_driver {
const struct file_operations *fops;
struct device *dev;
struct module *owner;
struct irctl *irctl;
};
/* following functions can be called ONLY from user context
*
* returns negative value on error or minor number
* of the registered device if success
* returns negative value on error or zero
* contents of the structure pointed by p is copied
*/
extern int lirc_register_driver(struct lirc_driver *d);
int lirc_register_driver(struct lirc_driver *d);
/* returns negative value on error or 0 if success
*/
extern int lirc_unregister_driver(int minor);
void lirc_unregister_driver(struct lirc_driver *d);
/* Returns the private data stored in the lirc_driver
* associated with the given device file pointer.