kybaaz/linux-xiaomi-chiron
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

backlight: qcom-wled: Pass number of elements to read to read_u32_array

Browse source 
of_property_read_u32_array takes the number of elements to read as last
argument. This does not always need to be 4 (sizeof(u32)) but should
instead be the size of the array in DT as read just above with
of_property_count_elems_of_size.

To not make such an error go unnoticed again the driver now bails
accordingly when of_property_read_u32_array returns an error.

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
This commit is contained in:
Marijn Suijten 2021-03-01 23:09:59 +01:00 • committed by Jami Kettunen
parent aaa397f95a
commit af4b70fff2
1 changed files with 10 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

13
drivers/video/backlight/qcom-wled.c
View file

@ -1528,11 +1528,18 @@ static int wled_configure(struct wled *wled)
string_len = of_property_count_elems_of_size(dev->of_node,
"qcom,enabled-strings",
sizeof(u32));
if (string_len > 0)
of_property_read_u32_array(dev->of_node,
if (string_len > 0) {
rc = of_property_read_u32_array(dev->of_node,
"qcom,enabled-strings",
wled->cfg.enabled_strings,
sizeof(u32));
string_len);
if (rc) {
dev_err(dev, "Failed to read %d elements from "
"qcom,enabled-strings: %d\n",
string_len, rc);
return -EINVAL;
}
}
return 0;
}