kybaaz/linux-xiaomi-chiron
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

PANELS TODO FINISHME: use dev_err_probe in _probe!

Browse source
This commit is contained in:
Marijn Suijten 2021-03-22 11:06:21 +01:00 • committed by Jami Kettunen
parent 7ed205734a
commit 9deca0ad10
2 changed files with 16 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

29
drivers/gpu/drm/panel/panel-td4322-innolux-fhd.c
View file

@ -195,17 +195,12 @@ static int td4322_innolux_fhd_probe(struct mipi_dsi_device *dsi)
ctx->supplies[3].supply = "vsp";
ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(ctx->supplies),
ctx->supplies);
if (ret < 0) {
dev_err(dev, "Failed to get regulators: %d\n", ret);
return ret;
}
if (ret < 0)
return dev_err_probe(dev, ret, "Failed to get regulators\n");
ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
if (IS_ERR(ctx->reset_gpio)) {
ret = PTR_ERR(ctx->reset_gpio);
dev_err(dev, "Failed to get reset-gpios: %d\n", ret);
return ret;
}
if (IS_ERR(ctx->reset_gpio))
return dev_err_probe(dev, PTR_ERR(ctx->reset_gpio), "Failed to get reset-gpios\n");
ctx->dsi = dsi;
mipi_dsi_set_drvdata(dsi, ctx);
@ -219,22 +214,14 @@ static int td4322_innolux_fhd_probe(struct mipi_dsi_device *dsi)
DRM_MODE_CONNECTOR_DSI);
ret = drm_panel_of_backlight(&ctx->panel);
if (ret) {
dev_err(dev, "Failed to get backlight: %d\n", ret);
return ret;
}
if (ret)
return dev_err_probe(dev, ret, "Failed to get backlight\n");
drm_panel_add(&ctx->panel);
if (ret < 0) {
dev_err(dev, "Failed to add panel: %d\n", ret);
return ret;
}
ret = mipi_dsi_attach(dsi);
if (ret < 0) {
dev_err(dev, "Failed to attach to DSI host: %d\n", ret);
return ret;
}
if (ret < 0)
return dev_err_probe(dev, ret, "Failed to attach to DSI host\n");
return 0;
}

29
drivers/gpu/drm/panel/panel-td4328-tianma-fhdplus.c
View file

@ -198,17 +198,12 @@ static int td4328_tianma_fhdplus_probe(struct mipi_dsi_device *dsi)
ctx->supplies[3].supply = "vsp";
ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(ctx->supplies),
ctx->supplies);
if (ret < 0) {
dev_err(dev, "Failed to get regulators: %d\n", ret);
return ret;
}
if (ret < 0)
return dev_err_probe(dev, ret, "Failed to get regulators\n");
ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
if (IS_ERR(ctx->reset_gpio)) {
ret = PTR_ERR(ctx->reset_gpio);
dev_err(dev, "Failed to get reset-gpios: %d\n", ret);
return ret;
}
if (IS_ERR(ctx->reset_gpio))
return dev_err_probe(dev, PTR_ERR(ctx->reset_gpio), "Failed to get reset-gpios\n");
ctx->dsi = dsi;
mipi_dsi_set_drvdata(dsi, ctx);
@ -222,22 +217,14 @@ static int td4328_tianma_fhdplus_probe(struct mipi_dsi_device *dsi)
DRM_MODE_CONNECTOR_DSI);
ret = drm_panel_of_backlight(&ctx->panel);
if (ret) {
dev_err(dev, "Failed to get backlight: %d\n", ret);
return ret;
}
if (ret)
return dev_err_probe(dev, ret, "Failed to get backlight\n");
drm_panel_add(&ctx->panel);
if (ret < 0) {
dev_err(dev, "Failed to add panel: %d\n", ret);
return ret;
}
ret = mipi_dsi_attach(dsi);
if (ret < 0) {
dev_err(dev, "Failed to attach to DSI host: %d\n", ret);
return ret;
}
if (ret < 0)
return dev_err_probe(dev, ret, "Failed to attach to DSI host\n");
return 0;
}