kybaaz/linux-xiaomi-chiron
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

usb: dwc3: xilinx: Remove the extra freeing of clocks

Browse source 
The clocks are configured by devm_clk_bulk_get_all() in this driver. In
case of any error the clocks freeing will be handled automatically.
There is no need to explicitly free the clocks. Fix the same.

Fixes: 84770f028f ("usb: dwc3: Add driver for Xilinx platforms")
Signed-off-by: Manish Narani <manish.narani@xilinx.com>
Link: https://lore.kernel.org/r/1617904448-74611-3-git-send-email-manish.narani@xilinx.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Manish Narani 2021-04-08 23:24:08 +05:30 • committed by Greg Kroah-Hartman
parent 3a2a68ecb2
commit 124b11cc4f
1 changed files with 0 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
drivers/usb/dwc3/dwc3-xilinx.c
View file

@ -271,7 +271,6 @@ static int dwc3_xlnx_probe(struct platform_device *pdev)
err_clk_put:
clk_bulk_disable_unprepare(priv_data->num_clocks, priv_data->clks);
clk_bulk_put_all(priv_data->num_clocks, priv_data->clks);
return ret;
}
@ -284,7 +283,6 @@ static int dwc3_xlnx_remove(struct platform_device *pdev)
of_platform_depopulate(dev);
clk_bulk_disable_unprepare(priv_data->num_clocks, priv_data->clks);
clk_bulk_put_all(priv_data->num_clocks, priv_data->clks);
priv_data->num_clocks = 0;
pm_runtime_disable(dev);