kybaaz/linux-xiaomi-chiron
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ACPI fixes for 5.9-rc3

Browse source 
- Avoid redundant rounding to the page size in acpi_os_map_iomem()
    to address a recently introduced issue with the EFI memory map
    permission check on ARM64 (Ard Biesheuvel).
 
  - Fix acpi_release_memory() to wait until the memory mappings
    released by it have been really unmapped (Rafael Wysocki).
 
  - Make the ACPI driver for AMD SoCs (APD) check the return value
    of acpi_dev_get_property() to avoid failures in the cases when the
    device property under inspection is missing (Furquan Shaikh).
 -----BEGIN PGP SIGNATURE-----
 
 iQJGBAABCAAwFiEE4fcc61cGeeHD/fCwgsRv/nhiVHEFAl9JXVESHHJqd0Byand5
 c29ja2kubmV0AAoJEILEb/54YlRxaykP/1g9wB6Kc5p/XSU66Ye3+ouqBjmwMgaG
 NUB4yR8L4YDscm7+b3LVabA1R5MJFjAiXHNjnZJIfZ/Fp9+cL+mqQCqM+M0t1m/d
 LLHyftmuDC1cg7Qr+N6ADoUvViB9AakSP5v7CVh5vEIp2Tm5T5VgZcJPXXlBjOpp
 kOMFFygA8WSpFaTG3kSScNv3dU9/+JhriOSvTAVUHcjz54abQaWQGFjjlEDhKvGU
 O5/W6eY8dOnowWdxLWyqYGPKZOtHPfGd/aAg0sus0Qcrth6Kbo49n88tqx+7Obyd
 pozrMS58hARYXHOwvvG4oIG4SH8pudrqFlYEv6UC89DvjxpPV3o4wNxeWVWVaZXL
 gWXyoeDlWqd4zx1EiIcKaBdtsMUZ+BlUkz47vqemkObLbswfoKOysQqE/VAZui0o
 yRZ5AaZm71BxxtgoBpplSIRCHT9eyhJaHIrokF6urCJX3ilIZPd+VZznx1soUSX4
 q2J/XuvF2iTdTwlCNK3yFizlStHjObkHkiWyklUbWi6Ga/A3E/Ny+OEPiZKJ034T
 +osn6sJDF29dp0XeOnFoqY22CSsfof/zQ//N1JujTxmq4RRDQEMMkisdhKNRSSI4
 VAI7srlgmx4b6iH4NRyNxiPL2Og24FKn1kIwGlJMfDJ9BbAGd7SulMx7xxeg66Gl
 gjGvVn8YNjUj
 =QccF
 -----END PGP SIGNATURE-----

Merge tag 'acpi-5.9-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm

Pull ACPI fixes from Rafael Wysocki:
 "These fix two recent issues in the ACPI memory mappings management
  code and tighten up error handling in the ACPI driver for AMD SoCs
  (APD).

  Specifics:

   - Avoid redundant rounding to the page size in acpi_os_map_iomem() to
     address a recently introduced issue with the EFI memory map
     permission check on ARM64 (Ard Biesheuvel).

   - Fix acpi_release_memory() to wait until the memory mappings
     released by it have been really unmapped (Rafael Wysocki).

   - Make the ACPI driver for AMD SoCs (APD) check the return value of
     acpi_dev_get_property() to avoid failures in the cases when the
     device property under inspection is missing (Furquan Shaikh)"

* tag 'acpi-5.9-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm:
  ACPI: OSL: Prevent acpi_release_memory() from returning too early
  ACPI: ioremap: avoid redundant rounding to OS page size
  ACPI: SoC: APD: Check return value of acpi_dev_get_property()
This commit is contained in:
Linus Torvalds 2020-08-28 13:17:14 -07:00
commit 0b2f18e7ae
2 changed files with 21 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

4
drivers/acpi/acpi_apd.c
View file

@ -99,8 +99,8 @@ static int fch_misc_setup(struct apd_private_data *pdata)
if (ret < 0)
return -ENOENT;
acpi_dev_get_property(adev, "is-rv", ACPI_TYPE_INTEGER, &obj);
clk_data->is_rv = obj->integer.value;
if (!acpi_dev_get_property(adev, "is-rv", ACPI_TYPE_INTEGER, &obj))
clk_data->is_rv = obj->integer.value;
list_for_each_entry(rentry, &resource_list, node) {
clk_data->base = devm_ioremap(&adev->dev, rentry->res->start,

23
drivers/acpi/osl.c
View file

@ -350,7 +350,7 @@ void __iomem __ref
pg_off = round_down(phys, PAGE_SIZE);
pg_sz = round_up(phys + size, PAGE_SIZE) - pg_off;
virt = acpi_map(pg_off, pg_sz);
virt = acpi_map(phys, size);
if (!virt) {
mutex_unlock(&acpi_ioremap_lock);
kfree(map);
@ -358,7 +358,7 @@ void __iomem __ref
}
INIT_LIST_HEAD(&map->list);
map->virt = virt;
map->virt = (void __iomem __force *)((unsigned long)virt & PAGE_MASK);
map->phys = pg_off;
map->size = pg_sz;
map->track.refcount = 1;
@ -1575,11 +1575,26 @@ static acpi_status acpi_deactivate_mem_region(acpi_handle handle, u32 level,
acpi_status acpi_release_memory(acpi_handle handle, struct resource *res,
u32 level)
{
acpi_status status;
if (!(res->flags & IORESOURCE_MEM))
return AE_TYPE;
return acpi_walk_namespace(ACPI_TYPE_REGION, handle, level,
acpi_deactivate_mem_region, NULL, res, NULL);
status = acpi_walk_namespace(ACPI_TYPE_REGION, handle, level,
acpi_deactivate_mem_region, NULL,
res, NULL);
if (ACPI_FAILURE(status))
return status;
/*
* Wait for all of the mappings queued up for removal by
* acpi_deactivate_mem_region() to actually go away.
*/
synchronize_rcu();
rcu_barrier();
flush_scheduled_work();
return AE_OK;
}
EXPORT_SYMBOL_GPL(acpi_release_memory);